Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assemble-release-plan): add includePrerelease for semver satisfies in shouldBumpMajor #1342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(assemble-release-plan): add includePrerelease for semver satisfies in shouldBumpMajor #1342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/assemble-release-plan/src/determine-dependents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,12 @@ function shouldBumpMajor({
// 1. If onlyUpdatePeerDependentsWhenOutOfRange set to true, bump major if the version is leaving the range.
// 2. If onlyUpdatePeerDependentsWhenOutOfRange set to false, bump major regardless whether or not the version is leaving the range.
(!onlyUpdatePeerDependentsWhenOutOfRange ||
!semverSatisfies(incrementVersion(nextRelease, preInfo), versionRange)) &&
!semverSatisfies(
incrementVersion(nextRelease, preInfo),
versionRange,
// eslint-disable-next-line prettier/prettier
{ includePrerelease: preInfo !== undefined }
)) &&
// bump major only if the dependent doesn't already has a major release.
(!releases.has(dependent) ||
(releases.has(dependent) && releases.get(dependent)!.type !== "major"))
Expand Down