Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag private packages when their version changes #662
Tag private packages when their version changes #662
Changes from 28 commits
626cfdf
5686490
6d37ea5
8e5354a
53742d5
60a1930
9d22a27
e571a0e
d2f4d89
013e969
8644724
f3c7ded
86171cb
44f2bd6
bae290b
49614eb
c356ae3
656d28f
24f0a78
f17508a
3886e90
c062b16
f0ece83
4dd972e
6047290
2f158d5
3e9f3b9
ce2f1d2
99d233b
30b6004
7bdce4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import type { PackageJSON } from "@changesets/types";
I think both import can be type import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is something wrong here? because
config.privatePackages
is alwaysObject
or i misunderstand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mino01x is it causing an issue? If it is then we need to write a test around it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#985 yes i have create a pr. you can help me to check it.