Fixed issues with * ranges not being replaced in premode
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 0a24e34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a24e34:
|
Andarist
force-pushed
the
fix/first-batch-workspace-ranges
branch
from
a4914e5
to
0a24e34
Compare
emmatown
reviewed
Dec 13, 2021
| // intentionally keep other workspace ranges untouched | ||
| // this has to be fixed but this should only be done when adding appropriate tests | ||
| versionRange === "workspace:*" | ||
| ? // workspace:* actually means the current exact version, and not a wildcard similar to a reguler * range |
There was a problem hiding this comment.
Hehe, ye - this is weird. Basically workspace:* means "replace with the current version (exact)", workspace:^ means "replace with the current version, modified with ^" (and the same applies to workspace:~).
emmatown
approved these changes
Jan 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.