Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with incorrect dependent updates on none changesets with updateInternalDependents: "always" #949

Merged
merged 9 commits into from Sep 19, 2022
Merged

Fixed an issue with incorrect dependent updates on none changesets with updateInternalDependents: "always" #949

merged 9 commits into from Sep 19, 2022

Commits on Sep 17, 2022

  1. Add tests to showcase buggy behaviour 

    Test that when `updateInternalDependents:'always'` is set then
transitive dependencies of devDependencies should not be part of the
release plan.
    @BPScott
    BPScott committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    2fad25d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. Fixed the issue

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    da2552f View commit details
    Browse the repository at this point in the history

  2. Tweak test title

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    8fcdebe View commit details
    Browse the repository at this point in the history

  3. Check first if the nextRelease is none

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    ff27d25 View commit details
    Browse the repository at this point in the history

  4. Remove the redundant indentation

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    1e39563 View commit details
    Browse the repository at this point in the history

  5. Tweak launch.json

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    8be8b05 View commit details
    Browse the repository at this point in the history

  6. Add changeset

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    d937828 View commit details
    Browse the repository at this point in the history

  7. Add test case and juggle some tests into their appropriate blocks

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    82d5ff1 View commit details
    Browse the repository at this point in the history

  8. Add a simpler test case too

    @Andarist
    Andarist committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    f344afb View commit details
    Browse the repository at this point in the history