Fix(cli): the problem of isListablePackage condition #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7513ab5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7513ab5:
|
Andarist
reviewed
Oct 19, 2022
| @@ -8,7 +8,7 @@ export function isListablePackage(config: Config, packageJson: PackageJSON) { | |||
| return false; | |||
| } | |||
|
|
|||
| if (!config.privatePackages && packageJson.private) { | |||
| if (!config.privatePackages?.version && packageJson.private) { | |||
There was a problem hiding this comment.
Could you add a test case that would cover the fix?
Isn't config.privatePackages always an object? If yes, shouldn't it be this?
Suggested change
| if (!config.privatePackages?.version && packageJson.private) { | |
| if (!config.privatePackages.version && packageJson.private) { |
There was a problem hiding this comment.
i have added test case, is that ok?
mino01x
force-pushed
the
fix/isListablePackage
branch
from
49b4856
to
f831c88
Compare
|
Just needs a changeset |
Andarist
reviewed
Oct 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.