Misc Cleanups #573
Merged
Misc Cleanups #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work around lerna/lerna#1171. The lerna publishing commands don't seem to update the yarn.lock file, unfortunately. This means on CI when we run `yarn install --immutable` we get an error because yarn tries to make changes to the lockfile (which lerna should have, but didn't, make). If we specify with dependencies between workspace packages with https://yarnpkg.com/features/workspaces/#workspace-ranges-workspace, then everything works because the version number of the packages doesn't actually appear in the yarn.lock file, and therefore doesn't need to get updated.
ahuth
commented
Aug 6, 2021
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 21 21
Lines 298 298
Branches 89 89
=======================================
Hits 284 284
Misses 14 14 Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 52.58 KB (0%) |
| styles | 3.91 KB (0%) |
… packages" This reverts commit 4e1e5ca.
ahuth
commented
Aug 6, 2021
| @@ -61,9 +61,6 @@ | |||
| "@babel/preset-typescript": "^7.12.17", | |||
| "@chanzuckerberg/axe-storybook-testing": "^3.0.2", | |||
| "@chanzuckerberg/story-utils": "^2.0.0", | |||
| "@commitlint/cli": "^8.3.5", | |||
| "@commitlint/config-conventional": "^8.3.4", | |||
| "@commitlint/prompt-cli": "^8.3.5", | |||
There was a problem hiding this comment.
No need to have v8 here and v11 at the top level.
|
This pull request has been linked to Clubhouse Story #132355: Remove classnames import (in favor of using clsx) from EDS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes a couple miscellaneous cleanups
Uses workspace ranges to define dependencies between packages to work aroundpublishandbootstrapnot update yarn.lock when internal dependencies version increment lerna/lerna#1171lerna runthat I missed in Migrate to Yarn v3 #533.Test Plan:
Alpha version publishThis didn't work, so I'll need to figure something else out. Removing the workspace ranges stuff