Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the yarn.lock file gets updated when publishing #575

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

ahuth
Copy link
Contributor

@ahuth ahuth commented Aug 6, 2021

Hat tip @anniehu4 for the idea here

Summary:

Currently Lerna doesn't update yarn.lock files when dependencies between monorepo packages increment. See lerna/lerna#1171.

To work around that, we manually install deps during publishing so that the lock file gets updated.

Another workaround would be to use Yarn workspace ranges to specify dependencies between package, so that there's no need to reference specific version numbers.

Unfortunately, Lerna also doesn't support that, either - lerna/lerna#2564.

Test Plan:

  • Create a test release (didn't publish it)

@ahuth ahuth requested a review from a team August 6, 2021 20:21
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #575 (e499b40) into main (2253e99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          21       21           
  Lines         298      298           
  Branches       89       89           
=======================================
  Hits          284      284           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2253e99...e499b40. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size
components 52.58 KB (0%)
styles 3.91 KB (0%)

Copy link
Contributor

@anniehu4 anniehu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ahuth ahuth merged commit bb1415f into main Aug 9, 2021
@ahuth ahuth deleted the ah-version branch August 9, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants