Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gush::Job#skip! #66

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ace-subido
Copy link

As per discussion in #65 this pull request adds a Gush::Job#skip! that would mark a job as skipped, and returns from the point where self.skip! is called. After calling self.skip!, the workflow continues on with the other jobs.

Note: @pokonski was thinking of adding .skip_remaining! on another PR to keep the PR's small. What do you think? Or should I include that suggestion in this PR too?

@pokonski
Copy link
Contributor

pokonski commented Jun 6, 2019

I tested it but have one note: could you add an integration spec for this case just to make sure descendants run?

Here: https://github.com/chaps-io/gush/blob/master/spec/features/integration_spec.rb

@natemontgomery
Copy link

@ace-subido I wanted to check in and see about updating this, it's something I think is worth implementing for sure! If you would rather not handle updating the branch I can hop on it, would definitely rather not duplicate a PR.

@ace-subido
Copy link
Author

for sure! go ahead, I've not worked/looked on this for a long time and you may have better context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants