Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure basePath #335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

plach79
Copy link

@plach79 plach79 commented Oct 18, 2022

This updates the SimpleOauth preview URL generator to support the basePath setting.

basePath

@vercel
Copy link

vercel bot commented Oct 18, 2022

Someone is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

@shadcn
Copy link
Collaborator

shadcn commented Nov 9, 2022

@plach79 Thanks for the PR. Can you elaborate on what this does please? Thank you.

@plach79
Copy link
Author

plach79 commented Nov 9, 2022

@shadcn

@plach79 Thanks for the PR. Can you elaborate on what this does please? Thank you.

Sorry for not being more explicit, it allows to work with a Next app having a basePath config value different from '', e.g. being served at https://example.org/next/, while https://example.org/ is reserved for another website.

@shadcn shadcn added enhancement New feature or request area: next module labels Nov 30, 2022
@JohnAlbin
Copy link
Collaborator

How is this different than just setting the base path as part of the base url on admin/config/services/next/sites/[some-site]/edit?

site-config-screenshot

@JohnAlbin JohnAlbin added the need more info Maintainers need more info label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: next module enhancement New feature or request need more info Maintainers need more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants