better handle errors raised while applying filterwarnings (pytest-dev…

…#7864)
charlesaracil-ulti · Oct 9, 2020 · 79abdcb · 79abdcb
1 parent dbd082a
commit 79abdcb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/changelog/7864.improvement.rst b/changelog/7864.improvement.rst
@@ -0,0 +1 @@
+better handle errors raised while applying filterwarnings
diff --git a/src/_pytest/config/__init__.py b/src/_pytest/config/__init__.py
@@ -1569,7 +1569,14 @@ def parse_warning_filter(
         parts.append("")
     action_, message, category_, module, lineno_ = [s.strip() for s in parts]
     action: str = warnings._getaction(action_)  # type: ignore[attr-defined]
-    category: Type[Warning] = warnings._getcategory(category_)  # type: ignore[attr-defined]
+    try:
+        category: Type[Warning] = warnings._getcategory(category_)  # type: ignore[attr-defined] # noqa: E501
+    except Exception as e:
+        raise Exception(
+            "Error while processing warning rules. Please make sure importing "
+            "the warning classes defined in filterwarning doesn't trigger an "
+            "exception."
+        ) from e
     if message and escape:
         message = re.escape(message)
     if module and escape: