Convert JVM target to use KMP

[krzema12]

No description provided.

[krzema12]

I have to drop working on this, sorry! Feel free to take over.

[westnordost]

Could you summarize what is still missing in this PR? Do you think it would require adjustments in snakeyaml-engine-kmp itself?

[krzema12]

@westnordost for sure the JVM-specific API, not sure what more. I recall not being able to get past some failures in unit tests. If some changes are needed in snakeyaml-engine-kmp, I'm the owner of it, so I'll be glad to help. Not sure if any changes will be needed.

[aSemy]

I've picked this up and I've managed to get the existing tests passing 🎉.

@krzema12 Would you be able to merge these PRs?

• Convert jvm to use kmp: implement reading/writing from Java input/output streams krzema12/kaml#2
• Tidy MarkedYamlEngineException krzema12/snakeyaml-engine-kmp#135

[krzema12]

Awesome, thanks @aSemy! Next step, on me: release snakeyaml-engine-kmp with your fix so that we can use it in this PR.

[krzema12]

https://github.com/krzema12/snakeyaml-engine-kmp/releases/tag/v2.7.2

@edit: I think the release is broken, see https://repo.maven.apache.org/maven2/it/krzeminski/snakeyaml-engine-kmp-js/2.7.2/ - almost no artifacts. That's why CI fails. I'm gonna try again.

[krzema12]

@charleskorn could you review please?

[charleskorn]

Sorry for the slow response to this, I've been a bit busy!

Thanks for working on this, this looks good overall.

[aSemy]

Regarding the disabled JS tests:

        browser {
            testTask {
                // TODO: enable once the tests work with Kotlin/JS.
                enabled = false
            }
        }
        nodejs {
            testTask {
                // TODO: enable once the tests work with Kotlin/JS.
                enabled = false
            }
        }

I've implemented a workaround in Kotest, so nested tests should work.

kotest/kotest#3913

So, please +1 and review that PR :)

[charleskorn]

Thanks for the PR @krzema12 and @aSemy!

[westnordost]

Very cool, thanks for your work on this, @krzema12 and @aSemy !