chore: switch to x/ansi for text manipulation #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to be consistent with Lipgloss and charmbracelet/lipgloss#279
aymanbagabas
requested review from
meowgorithm,
muesli and
maaslalani
as code owners
|
P.S. @mikelorant I haven't tested any of the bubbles yet |
|
Looks like we need to check:
|
|
@aymanbagabas Have confirmed that both I believe this is safe to merge. |
mikelorant
approved these changes
Apr 20, 2024
caarlos0
approved these changes
Apr 24, 2024
|
@meowgorithm @aymanbagabas Can we look at getting this one merged? This should mean we are free of the legacy string width functions in all the important places. |
aymanbagabas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to be consistent with Lipgloss and charmbracelet/lipgloss#279