Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Coordinates mouse reporting & additional buttons support #594

Merged
merged 4 commits into from Dec 4, 2023

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Nov 10, 2022

The X10 mouse protocol limits the X and Y coordinates to 223. This adds SGR (1006) mode to enable extended mouse events support.

  • Add shift modifier support
  • Support left/right wheel buttons (codes 6 & 7)
  • Support additional mouse button (codes 8-11)
  • Report which button was released (SGR feature)

Wants: muesli/termenv#104

Fixes: #359
Fixes: #718

@aymanbagabas aymanbagabas marked this pull request as draft November 10, 2022 17:17
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 4 times, most recently from decd02a to 1e450d4 Compare November 14, 2022 23:54
@aymanbagabas aymanbagabas changed the title Extended Coordinates mouse support Extended Coordinates mouse parse support Nov 15, 2022
examples/mouse/main.go Outdated Show resolved Hide resolved
mouse.go Show resolved Hide resolved
mouse.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 2 times, most recently from 7fa30ef to 5b0862c Compare October 4, 2023 16:58
Support SGR(1006) mouse mode
Support parsing shift key press
Support additional mouse buttons
Report which button was released
Report button motion
key.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas merged commit a154847 into master Dec 4, 2023
18 checks passed
@aymanbagabas aymanbagabas deleted the ext-mouse branch December 4, 2023 16:51
aymanbagabas added a commit that referenced this pull request Mar 1, 2024
This was probably a typo since the `w` gets set again during
`detectOneMsg` it wouldn't make sense to initially set it to `07` and it
makes the code confusing.

Fixes: a154847 (feat: extended Coordinates mouse reporting & additional buttons support (#594))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants