Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't concurrently change output profiles #172

Merged
merged 1 commit into from Feb 22, 2023
Merged

Commits on Feb 22, 2023

  1. fix: don't concurrently change output profiles

    Multiple lipgloss renderer instances can end up using the same default
    termenv.Output. This leads to a race condition when manipulating the
    ColorProfile concurrently.
    
    We could mutex protect the standard output in termenv, but it feels like
    a weak promise, as the rest of the Output wouldn't (and probably
    shouldn't) get protected. Protecting it in lipgloss itself would require
    a global lock however.
    
    I can't come up with a proper use-case for this scenario, and therefore
    we shift this responsibility to the user.
    muesli committed Feb 22, 2023
    Copy the full SHA
    c1c7d98 View commit details
    Browse the repository at this point in the history