Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bugs with border size calculation #197

Merged

Conversation

mieubrisse
Copy link

No description provided.

@mieubrisse mieubrisse changed the title Fix bugs with border size calculation fix: Fix bugs with border size calculation Apr 29, 2023
Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Do you mind excluding the changes to .gitignore from this PR? We like to keep our PRs very specific, and there are a lot of rules in there (like node stuff) that don鈥檛 apply to this type of project.

@mieubrisse
Copy link
Author

mieubrisse commented Apr 30, 2023

Sure - just pushed @meowgorithm . I'll open a separate PR with the VSCode and Idea one (I got hit by Git wanting to version control those)

@meowgorithm meowgorithm merged commit 7fef678 into charmbracelet:master May 1, 2023
9 checks passed
@meowgorithm
Copy link
Member

Thank you so much for this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants