Fix adding right padding to empty string #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meowgorithm Can I get approval to run the workflows? Thanks. |
|
Can I get someone from @charmbracelet to review this. Thanks. |
meowgorithm
requested changes
Jan 30, 2024
An empty string could not have padding applied on the right side. Issue: charmbracelet#252 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
mikelorant
force-pushed
the
fix/empty-string-pad-right
branch
from
79fdbeb
to
db8e999
Compare
|
Tests have been added. Needed a little refactor for the test function but now lets us control what text we render. Unit tests all passing. |
|
Nice work, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string could not have padding applied on the right side.
Issue: #252