Refactor padding functions #254
Conversation
mikelorant
force-pushed
the
refactor/padding
branch
from
5b3de33
to
62b8c0e
Compare
|
@meowgorithm Can I get approval to run the workflows? Thanks. |
|
Done. Nice work on this one. |
mikelorant
force-pushed
the
refactor/padding
branch
from
62b8c0e
to
3355f4e
Compare
|
Can I get someone from @charmbracelet to review this. Thanks. |
|
Good call on consolidating the two functions. If I'm reading this correctly negative integers applied to |
Yes, you reading this correctly. I am doing the conflict resolution now and will have this updated shortly. |
mikelorant
force-pushed
the
refactor/padding
branch
3 times, most recently
from
98a6610
to
16756d2
Compare
The `padLeft` and `padRight` functions were nearly identical and could benefit from being refactored to share common code. A new function called `pad` was added that applies padding based on the sign of the amount of padding needed. A positive value applies padding to the right side while a negative value applies padding to the left side. Issue: charmbracelet#252 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
mikelorant
force-pushed
the
refactor/padding
branch
from
16756d2
to
e261bf8
Compare
|
Added function comment to explain the relationship between positive and negative values. |
|
@meowgorithm Any improvements or changes you'd like to make? |
|
Looking good, @mikelorant—let's get it done. Thanks for the attention to detail! |
The
padLeftandpadRightfunctions were nearly identical and could benefit from being refactored to share common code.A new function called
padwas added that applies padding based on the sign of the amount of padding needed. A positive value applies padding to the right side while a negative value applies padding to the left side.Issue: #252