feat: trees and lists #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
* `New()` now take no args * added a new `Root(string)` method * added a new `Items(...any)` method
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
This is really cool! Ran all the examples on my machine and it looks rad 🥳 |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
Hey Charm team, this is awesome. When can we expect it to land into master? That's exactly what we're missing. Thanks! |
bashbunni
reviewed
Apr 17, 2024
bashbunni
reviewed
Apr 17, 2024
bashbunni
reviewed
Apr 17, 2024
bashbunni
reviewed
Apr 17, 2024
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Co-authored-by: bashbunni <15822994+bashbunni@users.noreply.github.com>
* chore(examples): go mod tidy * feat(tree): add rounded corner enumerator
|
Hey @testinfected we're still doing some usability tests on the API to decide if the developer experience is where we want it to be before release. No ETA yet, but the functionality is there, just want to make sure it's easy to use before publishing. We don't want to have to break the API in the future, so now's the time to get it all sorted :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on top of @maaslalani trees and lists implementations, fixed some bugs, refactor some stuff, added a couple of possibilities (namely, sublists (as trees)), etc.
Its a big PR, but it if it makes it better, it closes this 4 other PRs:
closes #242
closes #240
closes #243
closes #263
Some examples: