feat: Update new border info api (show information on bottom border) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorukot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is based on #97
I updated to allow the use of Chinese, Japanese, etc. (The original layout has problems when using these characters)
This function can be used to generate titles and info
func renderBorderContent(content string, contentStyle Style, border Border, width int)My English is not very good and I am not sure how to name those variables.
Please feel free to tell me if you need to change the variable names or anything!
If necessary, I can also create a PR to make border title apply this function
I really hope this can be put into release together with the title!