Skip to content

Commit

Permalink
Add index to legendItem interface (#10436)
Browse files Browse the repository at this point in the history
* Add index to legendItem interface for doughnut, pie and polarArea charts. Make datasetIndex optional since the before named charts dont include it.

* Remove test to check if datasetIndex has been set in generateLabels function for legend
  • Loading branch information
LeeLenaleee committed Jun 22, 2022
1 parent 8ee0c5c commit 0312697
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
7 changes: 6 additions & 1 deletion types/index.esm.d.ts
Expand Up @@ -2165,7 +2165,12 @@ export interface LegendItem {
/**
* Index of the associated dataset
*/
datasetIndex: number;
datasetIndex?: number;

/**
* Index the associated label in the labels array
*/
index?: number

/**
* Fill style of the legend box
Expand Down
7 changes: 0 additions & 7 deletions types/tests/plugins/defaults.ts
Expand Up @@ -9,10 +9,3 @@ defaults.plugins.legend.labels.generateLabels = function(chart) {
text: 'test'
}];
};

// @ts-expect-error Type '{ text: string; }[]' is not assignable to type 'LegendItem[]'.
defaults.plugins.legend.labels.generateLabels = function(chart) {
return [{
text: 'test'
}];
};

0 comments on commit 0312697

Please sign in to comment.