Fix DomPlatform.isAttached (#9448)

chartjs · Jul 23, 2021 · 0d0481d · 0d0481d
1 parent 3311377
commit 0d0481d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/platform/platform.dom.js b/src/platform/platform.dom.js
@@ -382,6 +382,6 @@ export default class DomPlatform extends BasePlatform {
 	 */
   isAttached(canvas) {
     const container = _getParentNode(canvas);
-    return !!(container && _getParentNode(container));
+    return !!(container && container.isConnected);
   }
 }
diff --git a/test/specs/platform.dom.tests.js b/test/specs/platform.dom.tests.js
@@ -408,17 +408,22 @@ describe('Platform.dom', function() {
       var platform = new DomPlatform();
       var canvas = document.createElement('canvas');
       var div = document.createElement('div');
+      var anotherDiv = document.createElement('div');
 
       expect(platform.isAttached(canvas)).toEqual(false);
       div.appendChild(canvas);
       expect(platform.isAttached(canvas)).toEqual(false);
-      document.body.appendChild(div);
+      anotherDiv.appendChild(div);
+      expect(platform.isAttached(canvas)).toEqual(false);
+      document.body.appendChild(anotherDiv);
 
       expect(platform.isAttached(canvas)).toEqual(true);
 
+      anotherDiv.removeChild(div);
+      expect(platform.isAttached(canvas)).toEqual(false);
       div.removeChild(canvas);
       expect(platform.isAttached(canvas)).toEqual(false);
-      document.body.removeChild(div);
+      document.body.removeChild(anotherDiv);
       expect(platform.isAttached(canvas)).toEqual(false);
     });
   });