Don't make legend empty when fill is false

chartjs · Nov 8, 2019 · 15dce00 · 15dce00
1 parent a985fec
commit 15dce00
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
@@ -346,10 +346,6 @@ helpers.extend(DatasetController.prototype, {
 			style = me._resolveDataElementOptions(meta.data[index] || {}, index);
 		}
 
-		if (style.fill === false || style.fill === null) {
-			style.backgroundColor = 'rgba(0,0,0,0)';
-		}
-
 		return style;
 	},
 

diff --git a/test/specs/plugin.legend.tests.js b/test/specs/plugin.legend.tests.js
@@ -149,7 +149,7 @@ describe('Legend block tests', function() {
 			datasetIndex: 1
 		}, {
 			text: 'dataset3',
-			fillStyle: 'rgba(0,0,0,0)',
+			fillStyle: 'rgba(0,0,0,0.1)',
 			hidden: false,
 			lineCap: 'butt',
 			lineDash: [],
@@ -198,7 +198,7 @@ describe('Legend block tests', function() {
 
 		expect(chart.legend.legendItems).toEqual([{
 			text: 'dataset3',
-			fillStyle: 'rgba(0,0,0,0)',
+			fillStyle: 'rgba(0,0,0,0.1)',
 			hidden: false,
 			lineCap: 'butt',
 			lineDash: [],