Remove scriptability from defaults.font types (#9794)

* Remove scriptability from defaults.font types * Remove failing test
chartjs · Oct 29, 2021 · 1749e57 · 1749e57
1 parent 10106e4
commit 1749e57
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts
@@ -1417,7 +1417,7 @@ export interface CoreChartOptions<TType extends ChartType> extends ParsingOption
    * base font
    * @see Defaults.font
    */
-  font: Scriptable<Partial<FontSpec>, ScriptableContext<TType>>;
+  font: Partial<FontSpec>;
   /**
    * Resizes the chart canvas when its container does (important note...).
    * @default true

diff --git a/types/tests/defaults.ts b/types/tests/defaults.ts
@@ -7,3 +7,16 @@ Chart.defaults.plugins.title.display = false;
 Chart.defaults.datasets.bar.backgroundColor = 'red';
 
 Chart.defaults.animation = { duration: 500 };
+
+Chart.defaults.font.size = 8;
+
+// @ts-expect-error should be number
+Chart.defaults.font.size = '8';
+
+// @ts-expect-error should be number
+Chart.defaults.font.size = () => '10';
+
+Chart.defaults.font = {
+  family: "'Helvetica Neue', 'Helvetica', 'Arial', sans-serif",
+  size: 10
+};
diff --git a/types/tests/scriptable_core_chart_options.ts b/types/tests/scriptable_core_chart_options.ts
@@ -8,7 +8,6 @@ const getConfig = (): ChartConfiguration<'bar'> => {
     },
     options: {
       backgroundColor: (context) => context.active ? '#fff' : undefined,
-      font: (context) => context.datasetIndex === 1 ? { size: 10 } : { size: 12, family: 'arial' }
     }
   };
 };