platform.isAttached should return false if canvas is false-y (#11707)

* platform.isAttached should return false if canvas is false-y * change styling to conform to codeclimate linter
chartjs · Mar 11, 2024 · 1777f95 · 1777f95
1 parent 7736ea3
commit 1777f95
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/helpers/helpers.dom.ts b/src/helpers/helpers.dom.ts
@@ -142,7 +142,7 @@ function getContainerSize(canvas: HTMLCanvasElement, width: number, height: numb
   let maxWidth: number, maxHeight: number;
 
   if (width === undefined || height === undefined) {
-    const container = _getParentNode(canvas);
+    const container = canvas && _getParentNode(canvas);
     if (!container) {
       width = canvas.clientWidth;
       height = canvas.clientHeight;

diff --git a/src/platform/platform.dom.js b/src/platform/platform.dom.js
@@ -383,7 +383,7 @@ export default class DomPlatform extends BasePlatform {
 	 * @param {HTMLCanvasElement} canvas
 	 */
   isAttached(canvas) {
-    const container = _getParentNode(canvas);
+    const container = canvas && _getParentNode(canvas);
     return !!(container && container.isConnected);
   }
 }