Better scale export (class with static _defaults)

chartjs · Jan 4, 2019 · 1d00765 · 1d00765
1 parent 1a7a36d
commit 1d00765
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 26 deletions.
diff --git a/src/chart.js b/src/chart.js
@@ -29,8 +29,8 @@ require('./core/core.controller')(Chart);
 
 // Register built-in scales
 var scales = require('./scales');
-Chart.helpers.each(scales, function(register) {
-	register();
+Chart.helpers.each(scales, function(scale, type) {
+	Chart.scaleService.registerScaleType(type, scale, scale._defaults);
 });
 
 // Loading built-in plugins

diff --git a/src/scales/scale.category.js b/src/scales/scale.category.js
@@ -1,13 +1,12 @@
 'use strict';
 
 var Scale = require('../core/core.scale');
-var scales = require('../core/core.scaleService');
 
 var defaultConfig = {
 	position: 'bottom'
 };
 
-var CategoryScale = Scale.extend({
+module.exports = Scale.extend({
 	/**
 	* Internal function to get the correct labels. If data.xLabels or data.yLabels are defined, use those
 	* else fall back to data.labels
@@ -131,6 +130,5 @@ var CategoryScale = Scale.extend({
 	}
 });
 
-module.exports = function() {
-	scales.registerScaleType('category', CategoryScale, defaultConfig);
-};
+// INTERNAL: static default options, registered in src/chart.js
+module.exports._defaults = defaultConfig;
diff --git a/src/scales/scale.linear.js b/src/scales/scale.linear.js
@@ -2,7 +2,6 @@
 
 var helpers = require('../helpers/index');
 var LinearScaleBase = require('./scale.linearbase');
-var scales = require('../core/core.scaleService');
 var Ticks = require('../core/core.ticks');
 
 var defaultConfig = {
@@ -12,7 +11,7 @@ var defaultConfig = {
 	}
 };
 
-var LinearScale = LinearScaleBase.extend({
+module.exports = LinearScaleBase.extend({
 	determineDataLimits: function() {
 		var me = this;
 		var opts = me.options;
@@ -187,6 +186,5 @@ var LinearScale = LinearScaleBase.extend({
 	}
 });
 
-module.exports = function() {
-	scales.registerScaleType('linear', LinearScale, defaultConfig);
-};
+// INTERNAL: static default options, registered in src/chart.js
+module.exports._defaults = defaultConfig;
diff --git a/src/scales/scale.logarithmic.js b/src/scales/scale.logarithmic.js
@@ -3,7 +3,6 @@
 var defaults = require('../core/core.defaults');
 var helpers = require('../helpers/index');
 var Scale = require('../core/core.scale');
-var scales = require('../core/core.scaleService');
 var Ticks = require('../core/core.ticks');
 
 /**
@@ -53,6 +52,7 @@ function generateTicks(generationOptions, dataRange) {
 	return ticks;
 }
 
+// INTERNAL: static default options, registered in src/chart.js
 var defaultConfig = {
 	position: 'left',
 
@@ -62,7 +62,7 @@ var defaultConfig = {
 	}
 };
 
-var LogarithmicScale = Scale.extend({
+module.exports = Scale.extend({
 	determineDataLimits: function() {
 		var me = this;
 		var opts = me.options;
@@ -347,6 +347,5 @@ var LogarithmicScale = Scale.extend({
 	}
 });
 
-module.exports = function() {
-	scales.registerScaleType('logarithmic', LogarithmicScale, defaultConfig);
-};
+// INTERNAL: static default options, registered in src/chart.js
+module.exports._defaults = defaultConfig;
diff --git a/src/scales/scale.radialLinear.js b/src/scales/scale.radialLinear.js
@@ -3,7 +3,6 @@
 var defaults = require('../core/core.defaults');
 var helpers = require('../helpers/index');
 var LinearScaleBase = require('./scale.linearbase');
-var scales = require('../core/core.scaleService');
 var Ticks = require('../core/core.ticks');
 
 var defaultConfig = {
@@ -316,7 +315,7 @@ function numberOrZero(param) {
 	return helpers.isNumber(param) ? param : 0;
 }
 
-var LinearRadialScale = LinearScaleBase.extend({
+module.exports = LinearScaleBase.extend({
 	setDimensions: function() {
 		var me = this;
 
@@ -529,6 +528,5 @@ var LinearRadialScale = LinearScaleBase.extend({
 	}
 });
 
-module.exports = function() {
-	scales.registerScaleType('radialLinear', LinearRadialScale, defaultConfig);
-};
+// INTERNAL: static default options, registered in src/chart.js
+module.exports._defaults = defaultConfig;
diff --git a/src/scales/scale.time.js b/src/scales/scale.time.js
@@ -488,7 +488,7 @@ var defaultConfig = {
 	}
 };
 
-var TimeScale = Scale.extend({
+module.exports = Scale.extend({
 	initialize: function() {
 		if (!moment) {
 			throw new Error('Chart.js - Moment.js could not be found! You must include it before Chart.js to use the time scale. Download at https://momentjs.com');
@@ -788,6 +788,5 @@ var TimeScale = Scale.extend({
 	}
 });
 
-module.exports = function() {
-	scales.registerScaleType('time', TimeScale, defaultConfig);
-};
+// INTERNAL: static default options, registered in src/chart.js
+module.exports._defaults = defaultConfig;