Skip to content

Commit

Permalink
Time Point Data sample works correctly (#5328)
Browse files Browse the repository at this point in the history
  • Loading branch information
etimberg committed Mar 13, 2018
1 parent 7f4b1d9 commit 25f2634
Showing 1 changed file with 8 additions and 19 deletions.
27 changes: 8 additions & 19 deletions samples/scales/time/line-point-data.html
Expand Up @@ -121,27 +121,16 @@

window.myLine.update();
});

// TODO : fix issue with addData
// See https://github.com/chartjs/Chart.js/issues/5197
// The Add Data button for this sample has no effect.
// An error is logged in the console.
document.getElementById('addData').addEventListener('click', function() {
if (config.data.datasets.length > 0) {
var numTicks = window.myLine.scales['x-axis-0'].ticksAsTimestamps.length;
var lastTime = numTicks ? moment(window.myLine.scales['x-axis-0'].ticksAsTimestamps[numTicks - 1]) : moment();

var newTime = lastTime
.clone()
.add(1, 'day')
.format('MM/DD/YYYY HH:mm');

for (var index = 0; index < config.data.datasets.length; ++index) {
config.data.datasets[index].data.push({
x: newTime,
y: randomScalingFactor()
});
}
config.data.datasets[0].data.push({
x: newDateString(config.data.datasets[0].data.length + 2),
y: randomScalingFactor()
});
config.data.datasets[1].data.push({
x: newDate(config.data.datasets[1].data.length + 2),
y: randomScalingFactor()
});

window.myLine.update();
}
Expand Down

0 comments on commit 25f2634

Please sign in to comment.