Input validation

chartjs · Jun 27, 2019 · 3722785 · 3722785
1 parent 9095a68
commit 3722785
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/helpers/helpers.math.js b/src/helpers/helpers.math.js
@@ -14,6 +14,10 @@ var exports = {
 		var sqrt = Math.sqrt(value);
 		var i;
 
+		if (!Number.isInteger(value) || value <= 0) {
+			throw new Error('_factorize expects a positive integer, but received ' + value);
+		}
+
 		for (i = 1; i < sqrt; i++) {
 			if (value % i === 0) {
 				result.push(i);

diff --git a/test/specs/helpers.math.tests.js b/test/specs/helpers.math.tests.js
@@ -10,5 +10,11 @@ describe('Chart.helpers.math', function() {
 		expect(factorize(24)).toEqual([1, 2, 3, 4, 6, 8, 12]);
 		expect(factorize(12)).toEqual([1, 2, 3, 4, 6]);
 		expect(factorize(4)).toEqual([1, 2]);
+		expect(function() {
+			factorize(-1);
+		}).toThrow(new Error('_factorize expects a positive integer, but received -1'));
+		expect(function() {
+			factorize(2.76);
+		}).toThrow(new Error('_factorize expects a positive integer, but received 2.76'));
 	});
 });