Lint before build & test, remove lint from test (#10462)

* Lint before build & test, remove lint from test * should reconize test now * test skip build in test step * readd build step
chartjs · Jul 7, 2022 · 3fe5811 · 3fe5811
1 parent cf6e1d2
commit 3fe5811
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -56,6 +56,8 @@ jobs:
               - 'tsconfig.json'
       - name: Install
         run: npm ci
+      - name: Lint
+        run: npm run lint
       - name: Build
         run: npm run build
       - name: Test
@@ -66,13 +68,11 @@ jobs:
         run: |
           npm run build
           if [ "${{ runner.os }}" == "macOS" ]; then
-            npm test --browsers chrome,safari
+            npm run test-ci --browsers chrome,safari
           else
-            xvfb-run --auto-servernum npm test
+            xvfb-run --auto-servernum npm run test-ci
           fi
         shell: bash
-      - name: Lint
-        run: npm run lint
       - name: Package
         if: steps.changes.outputs.docs == 'true'
         run: |

diff --git a/package.json b/package.json
@@ -46,7 +46,8 @@
         "lint-tsc": "tsc",
         "lint-types": "eslint \"types/**/*.ts\" && node -r esm types/tests/autogen.js && tsc -p types/tests/",
         "lint": "concurrently \"npm:lint-*\"",
-        "test": "npm run lint && cross-env NODE_ENV=test karma start --auto-watch --single-run --coverage --grep"
+        "test": "npm run lint && npm run test-ci",
+        "test-ci": "cross-env NODE_ENV=test karma start --auto-watch --single-run --coverage --grep"
     },
     "devDependencies": {
         "@kurkle/color": "^0.2.1",