Allow strings to be set

chartjs · May 1, 2021 · 4d4d8fe · 4d4d8fe
1 parent 9b2c5e5
commit 4d4d8fe
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts
@@ -1961,12 +1961,12 @@ interface BaseDecimationOptions {
 }
 
 interface LttbDecimationOptions extends BaseDecimationOptions {
-  algorithm: DecimationAlgorithm.lttb;
+  algorithm: DecimationAlgorithm.lttb | "lttb";
   samples?: number;
 }
 
 interface MinMaxDecimationOptions extends BaseDecimationOptions {
-  algorithm: DecimationAlgorithm.minmax;
+  algorithm: DecimationAlgorithm.minmax | "min-max";
 }
 
 export type DecimationOptions = LttbDecimationOptions | MinMaxDecimationOptions;

diff --git a/types/tests/plugins/plugin.decimation/decimation_algorithm.ts b/types/tests/plugins/plugin.decimation/decimation_algorithm.ts
@@ -16,3 +16,57 @@ const chart = new Chart('id', {
     }
   }
 });
+
+
+const chart2 = new Chart('id', {
+  type: 'bubble',
+  data: {
+    labels: [],
+    datasets: [{
+      data: []
+    }]
+  },
+  options: {
+    plugins: {
+      decimation: {
+        algorithm: 'lttb',
+      }
+    }
+  }
+});
+
+
+const chart3 = new Chart('id', {
+  type: 'bubble',
+  data: {
+    labels: [],
+    datasets: [{
+      data: []
+    }]
+  },
+  options: {
+    plugins: {
+      decimation: {
+        algorithm: DecimationAlgorithm.minmax,
+      }
+    }
+  }
+});
+
+
+const chart4 = new Chart('id', {
+  type: 'bubble',
+  data: {
+    labels: [],
+    datasets: [{
+      data: []
+    }]
+  },
+  options: {
+    plugins: {
+      decimation: {
+        algorithm: 'min-max',
+      }
+    }
+  }
+});