Skip to content

Commit

Permalink
Remove type attribute from dataset specific type specification (#10869)
Browse files Browse the repository at this point in the history
  • Loading branch information
LeeLenaleee committed Nov 13, 2022
1 parent 63993b0 commit 53b7967
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/plugins/plugin.colors.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Chart, ChartDataset} from '../types';
import type {Chart, ChartConfiguration, ChartDataset} from '../types';

export interface ColorsPluginOptions {
enabled?: boolean;
Expand Down Expand Up @@ -94,7 +94,7 @@ export default {
type,
options: {elements},
data: {datasets}
} = chart.config;
} = chart.config as ChartConfiguration;

if (containsColorsDefinitions(datasets) || elements && containsColorsDefinitions(elements)) {
return;
Expand Down
1 change: 0 additions & 1 deletion types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3651,7 +3651,6 @@ export interface ChartConfigurationCustomTypesPerDataset<
TData = DefaultDataPoint<TType>,
TLabel = unknown
> {
type: TType;
data: ChartDataCustomTypesPerDataset<TType, TData, TLabel>;
options?: ChartOptions<TType>;
plugins?: Plugin<TType>[];
Expand Down

0 comments on commit 53b7967

Please sign in to comment.