fix: calc visible points on update #10467

chartjs · Jul 28, 2022 · 69a82fa · 69a82fa
1 parent 8ccff8c
commit 69a82fa
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 1 deletion.
diff --git a/src/helpers/helpers.collection.js b/src/helpers/helpers.collection.js
@@ -33,7 +33,7 @@ export function _lookup(table, value, cmp) {
  * @private
  */
 export const _lookupByKey = (table, key, value) =>
-  _lookup(table, value, index => table[index][key] < value);
+  _lookup(table, value, index => table[index][key] <= value);
 
 /**
  * Reverse binary search

diff --git a/test/specs/controller.line.tests.js b/test/specs/controller.line.tests.js
@@ -1016,4 +1016,51 @@ describe('Chart.controllers.line', function() {
       expect(point.stop).toBe(i === 3);
     }
   });
+
+  it('should correctly calc visible points on update', async() => {
+    var chart = window.acquireChart({
+      type: 'line',
+      data: {
+        datasets: [{
+          data: [
+            {x: 10, y: 20},
+            {x: 15, y: 19},
+          ]
+        }],
+      },
+      options: {
+        scales: {
+          y: {
+            type: 'linear',
+            min: 0,
+            max: 25,
+          },
+          x: {
+            type: 'linear',
+            min: 0,
+            max: 50
+          },
+        }
+      }
+    });
+
+    chart.data.datasets[0].data = [
+      {x: 10, y: 20},
+      {x: 15, y: 19},
+      {x: 17, y: 12},
+      {x: 50, y: 9},
+      {x: 50, y: 9},
+      {x: 50, y: 9},
+    ];
+    chart.update();
+
+    var point = chart.getDatasetMeta(0).data[0];
+    var event = {
+      type: 'mousemove',
+      native: true,
+      ...point
+    };
+
+    chart._handleEvent(event, false, true);
+  }, 500);
 });