Skip to content

Commit

Permalink
reduce duplication
Browse files Browse the repository at this point in the history
  • Loading branch information
kurkle committed Nov 20, 2021
1 parent 18bde32 commit 83bc5e0
Showing 1 changed file with 6 additions and 14 deletions.
20 changes: 6 additions & 14 deletions src/platform/platform.dom.js
Expand Up @@ -114,16 +114,8 @@ function fromNativeEvent(event, chart) {
};
}

function wasAttached(entry, canvas) {
for (const node of entry.addedNodes) {
if (node === canvas || node.contains(canvas)) {
return true;
}
}
}

function wasDetached(entry, canvas) {
for (const node of entry.removedNodes) {
function nodeListContains(nodeList, canvas) {
for (const node of nodeList) {
if (node === canvas || node.contains(canvas)) {
return true;
}
Expand All @@ -135,8 +127,8 @@ function createAttachObserver(chart, type, listener) {
const observer = new MutationObserver(entries => {
let trigger = false;
for (const entry of entries) {
trigger = trigger || wasAttached(entry, canvas);
trigger = trigger && !wasDetached(entry, canvas);
trigger = trigger || nodeListContains(entry.addedNodes, canvas);
trigger = trigger && !nodeListContains(entry.removedNodes, canvas);
}
if (trigger) {
listener();
Expand All @@ -151,8 +143,8 @@ function createDetachObserver(chart, type, listener) {
const observer = new MutationObserver(entries => {
let trigger = false;
for (const entry of entries) {
trigger = trigger || wasDetached(entry, canvas);
trigger = trigger && !wasAttached(entry, canvas);
trigger = trigger || nodeListContains(entry.removedNodes, canvas);
trigger = trigger && !nodeListContains(entry.addedNodes, canvas);
}
if (trigger) {
listener();
Expand Down

0 comments on commit 83bc5e0

Please sign in to comment.