remove extra line in docs, implement feedback

chartjs · Dec 1, 2021 · 8475728 · 8475728
1 parent ff47c55
commit 8475728
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/developers/plugins.md b/docs/developers/plugins.md
@@ -148,7 +148,6 @@ Plugins can interact with the chart during the event handling process. The event
 
 ![Chart.js event handling flowchart](./event_flowchart.png)
 
-
 ### Chart destroy
 
 Plugins are notified during the destroy process. These hooks can be used to destroy things that the plugin made and used during its life.

diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -905,10 +905,12 @@ class Chart {
       this.ctx = null;
     }
 
+    // TODO V4: delete destroy hook and reference to it in plugin flowchart
     this.notifyPlugins('destroy');
-    this.notifyPlugins('afterDestroy');
 
     delete instances[this.id];
+
+    this.notifyPlugins('afterDestroy');
   }
 
   toBase64Image(...args) {