Allow individual chart controllers to opt-in to the decimation plugin

chartjs · Feb 20, 2022 · 876dc88 · 876dc88
1 parent 2f7550d
commit 876dc88
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js
@@ -6,8 +6,9 @@ import {_lookupByKey} from '../helpers/helpers.collection';
 export default class LineController extends DatasetController {
 
   initialize() {
-    this.enableOptionSharing = true;
     super.initialize();
+    this.enableOptionSharing = true;
+    this.supportsDecimation = true;
   }
 
   update(mode) {

diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
@@ -249,6 +249,7 @@ export default class DatasetController {
     this.linkScales();
     meta._stacked = isStacked(meta.vScale, meta);
     this.addElements();
+    this.supportsDecimation = false
   }
 
   updateIndex(datasetIndex) {

diff --git a/src/plugins/plugin.decimation.js b/src/plugins/plugin.decimation.js
@@ -217,7 +217,7 @@ export default {
         return;
       }
 
-      if (meta.type !== 'line') {
+      if (!meta.controller.supportsDecimation) {
         // Only line datasets are supported
         return;
       }

diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts
@@ -576,6 +576,10 @@ export class DatasetController<
   readonly index: number;
   readonly _cachedMeta: ChartMeta<TElement, TDatasetElement, TType>;
   enableOptionSharing: boolean;
+  // If true, the controller supports the decimation
+  // plugin. Defaults to `false` for all controllers
+  // except the LineController
+  supportsDecimation: boolean;
 
   linkScales(): void;
   getAllParsedValues(scale: Scale): number[];