Skip to content

Commit

Permalink
Fix control points on animated line w/o border (#9592)
Browse files Browse the repository at this point in the history
Co-authored-by: Jukka Kurkela <jukka.kurkela@scmbest.fi>
  • Loading branch information
kurkle and Jukka Kurkela committed Sep 2, 2021
1 parent 3ed9455 commit 8d68b11
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/elements/element.line.js
Expand Up @@ -395,15 +395,13 @@ export default class LineElement extends Element {
const options = me.options || {};
const points = me.points || [];

if (!points.length || !options.borderWidth) {
return;
}
if (points.length && options.borderWidth) {
ctx.save();

ctx.save();
draw(ctx, me, start, count);

draw(ctx, me, start, count);

ctx.restore();
ctx.restore();
}

if (me.animated) {
// When line is animated, the control points and path are not cached.
Expand Down
41 changes: 41 additions & 0 deletions test/fixtures/controller.line/fill/no-border.js
@@ -0,0 +1,41 @@
module.exports = {
config: {
type: 'line',
data: {
labels: [0, 1, 2, 3, 4, 5],
datasets: [
{
data: [12, 19, 3, 5, 2, 3],
backgroundColor: '#ff0000',
borderWidth: 0,
tension: 0.4,
fill: true
},
]
},
options: {
animation: {
duration: 1
},
scales: {
x: {display: false},
y: {display: false}
},
plugins: {
legend: false,
title: false,
tooltip: false,
filler: true
}
}
},
options: {
canvas: {
height: 256,
width: 512
},
run() {
return new Promise(resolve => setTimeout(resolve, 50));
}
}
};
Binary file added test/fixtures/controller.line/fill/no-border.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 8d68b11

Please sign in to comment.