Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Respect
fill: false
with custom draw times (#10414)
* Resolve canvasgradient is not defined in node * Remove trailing white space * export isPaternOrGradient helper with typings * fix lint failure, single qoute * Respect `fill: false` with custom draw times * correctly listen to fill property * remove console log and lint errors * implement feedback, still update control points
- Loading branch information
1 parent
3c3d53b
commit 954ed95
Showing
8 changed files
with
76 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
test/fixtures/plugin.filler/line/drawTimeFillFalse/beforeDatasetDraw.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module.exports = { | ||
config: { | ||
type: 'line', | ||
data: { | ||
labels: ['0', '1', '2', '3', '4', '5'], | ||
datasets: [{ | ||
backgroundColor: 'red', | ||
data: [3, -3, 0, 5, -5, 0], | ||
fill: false | ||
}] | ||
}, | ||
options: { | ||
plugins: { | ||
legend: false, | ||
title: false, | ||
filler: { | ||
drawTime: 'beforeDatasetDraw' | ||
} | ||
}, | ||
} | ||
}, | ||
}; |
Binary file added
BIN
+25.8 KB
test/fixtures/plugin.filler/line/drawTimeFillFalse/beforeDatasetDraw.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions
22
test/fixtures/plugin.filler/line/drawTimeFillFalse/beforeDatasetsDraw.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module.exports = { | ||
config: { | ||
type: 'line', | ||
data: { | ||
labels: ['0', '1', '2', '3', '4', '5'], | ||
datasets: [{ | ||
backgroundColor: 'red', | ||
data: [3, -3, 0, 5, -5, 0], | ||
fill: false | ||
}] | ||
}, | ||
options: { | ||
plugins: { | ||
legend: false, | ||
title: false, | ||
filler: { | ||
drawTime: 'beforeDatasetsDraw' | ||
} | ||
}, | ||
} | ||
}, | ||
}; |
Binary file added
BIN
+25.8 KB
test/fixtures/plugin.filler/line/drawTimeFillFalse/beforeDatasetsDraw.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions
22
test/fixtures/plugin.filler/line/drawTimeFillFalse/beforeDraw.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
module.exports = { | ||
config: { | ||
type: 'line', | ||
data: { | ||
labels: ['0', '1', '2', '3', '4', '5'], | ||
datasets: [{ | ||
backgroundColor: 'red', | ||
data: [3, -3, 0, 5, -5, 0], | ||
fill: false | ||
}] | ||
}, | ||
options: { | ||
plugins: { | ||
legend: false, | ||
title: false, | ||
filler: { | ||
drawTime: 'beforeDraw' | ||
} | ||
}, | ||
} | ||
}, | ||
}; |
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.