Skip to content

Commit

Permalink
Attempt to fix test flakiness (Firefox) (#4880)
Browse files Browse the repository at this point in the history
These settings deal with browser disconnects. We had seen test flakiness from Firefox:
[Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms
  • Loading branch information
benmccann authored and simonbrunel committed Oct 22, 2017
1 parent ee6432b commit 9f32f07
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion karma.conf.js
Expand Up @@ -14,7 +14,13 @@ module.exports = function(karma) {

browserify: {
debug: true
}
},

// These settings deal with browser disconnects. We had seen test flakiness from Firefox
// [Firefox 56.0.0 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.
// https://github.com/jasmine/jasmine/issues/1327#issuecomment-332939551
browserNoActivityTimeout: 60000,
browserDisconnectTolerance: 3
};

// https://swizec.com/blog/how-to-run-javascript-tests-in-chrome-on-travis/swizec/6647
Expand Down

0 comments on commit 9f32f07

Please sign in to comment.