Assign unique scale IDs (#6291)

chartjs · Jun 9, 2019 · bf094c5 · bf094c5
1 parent 70b32ff
commit bf094c5
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -137,6 +137,19 @@ function updateConfig(chart) {
 	chart.tooltip.initialize();
 }
 
+function nextAvailableScaleId(axesOpts, prefix, index) {
+	var id;
+	var hasId = function(obj) {
+		return obj.id === id;
+	};
+
+	do {
+		id = prefix + index++;
+	} while (helpers.findIndex(axesOpts, hasId) >= 0);
+
+	return id;
+}
+
 function positionIsHorizontal(position) {
 	return position === 'top' || position === 'bottom';
 }
@@ -295,11 +308,15 @@ helpers.extend(Chart.prototype, /** @lends Chart */ {
 		var scaleOptions = options.scale;
 
 		helpers.each(scalesOptions.xAxes, function(xAxisOptions, index) {
-			xAxisOptions.id = xAxisOptions.id || ('x-axis-' + index);
+			if (!xAxisOptions.id) {
+				xAxisOptions.id = nextAvailableScaleId(scalesOptions.xAxes, 'x-axis-', index);
+			}
 		});
 
 		helpers.each(scalesOptions.yAxes, function(yAxisOptions, index) {
-			yAxisOptions.id = yAxisOptions.id || ('y-axis-' + index);
+			if (!yAxisOptions.id) {
+				yAxisOptions.id = nextAvailableScaleId(scalesOptions.yAxes, 'y-axis-', index);
+			}
 		});
 
 		if (scaleOptions) {

diff --git a/test/specs/core.controller.tests.js b/test/specs/core.controller.tests.js
@@ -1059,6 +1059,23 @@ describe('Chart', function() {
 			expect(yScale.options.ticks.max).toBe(10);
 		});
 
+		it ('should assign unique scale IDs', function() {
+			var chart = acquireChart({
+				type: 'line',
+				options: {
+					scales: {
+						xAxes: [{id: 'x-axis-0'}, {}, {}],
+						yAxes: [{id: 'y-axis-1'}, {}, {}]
+					}
+				}
+			});
+
+			expect(Object.keys(chart.scales).sort()).toEqual([
+				'x-axis-0', 'x-axis-1', 'x-axis-2',
+				'y-axis-1', 'y-axis-2', 'y-axis-3'
+			]);
+		});
+
 		it ('should remove discarded scale', function() {
 			var chart = acquireChart({
 				type: 'line',