Hover styling for dataset in 'dataset' mode

chartjs · Sep 18, 2019 · c32fa33 · c32fa33
1 parent 29f1337
commit c32fa33
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js
@@ -315,4 +315,19 @@ module.exports = DatasetController.extend({
 		model.borderWidth = valueOrDefault(options.hoverBorderWidth, options.borderWidth);
 		model.radius = valueOrDefault(options.hoverRadius, options.radius);
 	},
+
+	setDatasetHoverStyle: function() {
+		var line = this.getMeta().dataset;
+		var model = line._model;
+		var config = this._config;
+		var getHoverColor = helpers.getHoverColor;
+
+		line.$previousStyle = {
+			backgroundColor: model.backgroundColor,
+			borderColor: model.borderColor
+		};
+
+		model.backgroundColor = valueOrDefault(config.hoverBackgroundColor, getHoverColor(config.backgroundColor));
+		model.borderColor = valueOrDefault(config.hoverBorderColor, getHoverColor(config.borderColor));
+	},
 });
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -964,6 +964,11 @@ helpers.extend(Chart.prototype, /** @lends Chart */ {
 				this.getDatasetMeta(element._datasetIndex).controller[method](element);
 			}
 		}
+
+		if (mode === 'dataset') {
+			method = enabled ? 'setDatasetHoverStyle' : 'removeDatasetHoverStyle';
+			this.getDatasetMeta(elements[0]._datasetIndex).controller[method]();
+		}
 	},
 
 	/**

diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
@@ -453,6 +453,12 @@ helpers.extend(DatasetController.prototype, {
 		model.borderWidth = resolve([custom.hoverBorderWidth, dataset.hoverBorderWidth, model.borderWidth], undefined, index);
 	},
 
+	removeDatasetHoverStyle: function() {
+		this.removeHoverStyle(this.getMeta().dataset);
+	},
+
+	setDatasetHoverStyle: helpers.noop,
+
 	/**
 	 * @private
 	 */