Remove #9152

chartjs · May 25, 2021 · efb9482 · efb9482
1 parent 67623c4
commit efb9482
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/src/elements/element.arc.js b/src/elements/element.arc.js
@@ -277,7 +277,7 @@ export default class ArcElement extends Element {
 	 * @param {boolean} [useFinalPosition]
 	 */
   getCenterPoint(useFinalPosition) {
-    const {x, y, startAngle, endAngle, innerRadius, outerRadius, circumference} = this.getProps([
+    const {x, y, startAngle, endAngle, innerRadius, outerRadius} = this.getProps([
       'x',
       'y',
       'startAngle',
@@ -286,7 +286,7 @@ export default class ArcElement extends Element {
       'outerRadius',
       'circumference'
     ], useFinalPosition);
-    const halfAngle = isNaN(circumference) ? (startAngle + endAngle) / 2 : startAngle + circumference / 2;
+    const halfAngle = (startAngle + endAngle) / 2;
     const halfRadius = (innerRadius + outerRadius) / 2;
     return {
       x: x + Math.cos(halfAngle) * halfRadius,

diff --git a/test/specs/element.arc.tests.js b/test/specs/element.arc.tests.js
@@ -66,35 +66,26 @@ describe('Arc element tests', function() {
     expect(center.y).toBeCloseTo(0.5, 6);
   });
 
-  it ('should get the center of full circle using endAngle', function() {
+  it ('should get the center of full circle before and after draw', function() {
     // Mock out the arc as if the controller put it there
     var arc = new Chart.elements.ArcElement({
       startAngle: 0,
       endAngle: Math.PI * 2,
       x: 2,
       y: 2,
       innerRadius: 0,
-      outerRadius: 2
+      outerRadius: 2,
+      options: {}
     });
 
     var center = arc.getCenterPoint();
     expect(center.x).toBeCloseTo(1, 6);
     expect(center.y).toBeCloseTo(2, 6);
-  });
 
-  it ('should get the center of full circle using circumference', function() {
-    // Mock out the arc as if the controller put it there
-    var arc = new Chart.elements.ArcElement({
-      startAngle: 0,
-      endAngle: 0,
-      x: 2,
-      y: 2,
-      innerRadius: 0,
-      outerRadius: 2,
-      circumference: Math.PI * 2
-    });
+    var ctx = window.createMockContext();
+    arc.draw(ctx);
 
-    var center = arc.getCenterPoint();
+    center = arc.getCenterPoint();
     expect(center.x).toBeCloseTo(1, 6);
     expect(center.y).toBeCloseTo(2, 6);
   });