Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scale polarArea correctly on data hide #10340

Merged
merged 3 commits into from May 22, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee commented May 5, 2022

Resolves: #10337

@LeeLenaleee LeeLenaleee added this to the Version 3.8.0 milestone May 5, 2022
etimberg
etimberg previously approved these changes May 5, 2022
kurkle
kurkle previously approved these changes May 5, 2022
src/controllers/controller.polarArea.js Outdated Show resolved Hide resolved
@LeeLenaleee LeeLenaleee dismissed stale reviews from kurkle and etimberg via 4f5b6f6 May 6, 2022 11:03
@etimberg
Copy link
Member

etimberg commented May 6, 2022

The windows build seems to continuously fail here :/

@stockiNail
Copy link
Contributor

The windows build seems to continuously fail here :/

If I may @etimberg, unfortunately not only here, the same in annotation plugin 😟

@etimberg
Copy link
Member

etimberg commented May 6, 2022

😦 maybe it's time to only have the ubuntu build.

@kurkle
Copy link
Member

kurkle commented May 6, 2022

The failures are usually timeouts. Could increase those limits, but otoh the windows test also takes a lot of time already.

@kurkle
Copy link
Member

kurkle commented May 6, 2022

Maybe we could do the build and lint only in windows (and not tests)

@etimberg etimberg merged commit 1422c93 into chartjs:master May 22, 2022
@LeeLenaleee LeeLenaleee deleted the bug/polarArea-scale-min-max branch May 22, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polar area chart not scaling on dataset hide
4 participants