Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scale polarArea correctly on data hide #10340

Merged
merged 3 commits into from May 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/controllers/controller.polarArea.js
Expand Up @@ -33,6 +33,30 @@ export default class PolarAreaController extends DatasetController {
this.updateElements(arcs, 0, arcs.length, mode);
}

/**
* @protected
*/
getMinMax() {
const meta = this._cachedMeta;
const range = {min: Number.POSITIVE_INFINITY, max: Number.NEGATIVE_INFINITY};

meta.data.forEach((element, index) => {
const parsed = this.getParsed(index).r;

if (!isNaN(parsed) && this.chart.getDataVisibility(index)) {
if (parsed < range.min) {
range.min = parsed;
}

if (parsed > range.max) {
range.max = parsed;
}
}
});

return range;
}

/**
* @private
*/
Expand Down
18 changes: 18 additions & 0 deletions test/specs/controller.polarArea.tests.js
@@ -1,6 +1,24 @@
describe('Chart.controllers.polarArea', function() {
describe('auto', jasmine.fixture.specs('controller.polarArea'));

it('should update the scale correctly when data visibility is changed', function() {
var expectedScaleMax = 1;
var chart = window.acquireChart({
type: 'polarArea',
data: {
datasets: [
{data: [100]}
],
labels: ['x']
}
});

chart.toggleDataVisibility(0);
chart.update();

expect(chart.scales.r.max).toBe(expectedScaleMax);
});

it('should be registered as dataset controller', function() {
expect(typeof Chart.controllers.polarArea).toBe('function');
});
Expand Down