Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calc visible points on update #10467 #10523

Merged
merged 1 commit into from Jul 28, 2022
Merged

fix: calc visible points on update #10467 #10523

merged 1 commit into from Jul 28, 2022

Conversation

dangreen
Copy link
Collaborator

Fix #10467

etimberg
etimberg previously approved these changes Jul 27, 2022
@etimberg etimberg added this to the Version 3.9.0 milestone Jul 27, 2022
LeeLenaleee
LeeLenaleee previously approved these changes Jul 27, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What breaks if it always uses <=?

My thought was to make sure the .hi is always the last (and .lo first) in case there are multiple equal values.

That said, I do not know if it would be easy to do or if it would result in slower code.

Would you be willing to ty it out?

@dangreen dangreen dismissed stale reviews from LeeLenaleee and etimberg via 69a82fa July 28, 2022 08:46
@dangreen
Copy link
Collaborator Author

dangreen commented Jul 28, 2022

@kurkle

What breaks if it always uses <=?

Tests are failing

Plugin.decimation
    lttb
      ✗ should draw all element only in range
	Error: Expected 3 to be 2.
	    at <Jasmine>
	    at UserContext.<anonymous> (test/specs/plugin.decimation.tests.js:176:48)
	    at <Jasmine>

	Error: Expected 4 to be 3.
	    at <Jasmine>
	    at UserContext.<anonymous> (test/specs/plugin.decimation.tests.js:177:48)
	    at <Jasmine>

	Error: Expected 5 to be 4.
	    at <Jasmine>
	    at UserContext.<anonymous> (test/specs/plugin.decimation.tests.js:178:48)
	    at <Jasmine>

	Error: Expected 6 to be 5.
	    at <Jasmine>
	    at UserContext.<anonymous> (test/specs/plugin.decimation.tests.js:179:48)
	    at <Jasmine>

	Error: Expected 7 to be 6.
	    at <Jasmine>
	    at UserContext.<anonymous> (test/specs/plugin.decimation.tests.js:180:48)
	    at <Jasmine>

@etimberg etimberg merged commit e800b46 into chartjs:master Jul 28, 2022
@dangreen dangreen deleted the fix-10467 branch July 28, 2022 12:08
@dangreen dangreen restored the fix-10467 branch September 12, 2022 18:02
@dangreen dangreen deleted the fix-10467 branch September 12, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chart.js 3.7.1: Error thrown after updating data and subsequent user interaction
4 participants