Fix range calculation when all datasets hidden and axis minimum set #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0 - 1. If `ticks.min` was set this would not set the range correctly. Added a test to cover this case as well
simonbrunel
reviewed
Jun 25, 2017
| @@ -27,6 +27,9 @@ module.exports = function(Chart) { | |||
| } | |||
| } | |||
|
|
|||
| var setMin = tickOpts.min !== undefined || tickOpts.suggestedMin !== undefined; | |||
There was a problem hiding this comment.
Should we also handle min/suggestedMin === null?
There was a problem hiding this comment.
Good question. I'm not sure. The only way that could happen is if a user explicitly sets it (the default is undefined)
simonbrunel
approved these changes
Jun 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4216
Cause
What happened in that bug was the following:
ticks.minproperty set which changes the default rangeFix
To fix this, the range is checked after
ticks.minandticks.maxare handled to ensure that the range is valid and thatmin < max.