fix #4216 when dataset empty, set scale min max to default if null #4258
Conversation
|
Have no idea why
|
src/scales/scale.linear.js
Outdated
| me.min = isFinite(me.min) ? me.min : DEFAULT_MIN; | ||
| me.max = isFinite(me.max) ? me.max : DEFAULT_MAX; | ||
| me.min = (me.min && isFinite(me.min)) ? me.min : DEFAULT_MIN; | ||
| me.max = (me.max && isFinite(me.max)) ? me.max : DEFAULT_MAX; |
There was a problem hiding this comment.
Is it intentional to use DEFAULT_MAX if max === 0 (same for min)?
There was a problem hiding this comment.
Sorry, meant to be not null. Have modified the commit.
xg-wang
force-pushed
the
fix/horizontal_bar_label
branch
from
a69c2b4
to
7d89160
Compare
src/scales/scale.linearbase.js
Outdated
| @@ -47,10 +47,10 @@ module.exports = function(Chart) { | |||
| } | |||
| } | |||
|
|
|||
| if (me.min === me.max) { | |||
There was a problem hiding this comment.
The previous commit is not enough. Say when we set min: 10 (whatever larger than default max), will result in me.min > me.max here but not processed correctly.
I changed this to be based on the opts' min setting if exists.
|
Just checked the two new failed tests, I guess they are set wrong. When I change the DEFAULT_MIN to be -1, the two tests will pass, but another test will fail. Should I create another test here for the case when tick.min is set, max value should be larger than the config min value? |
|
Looks good to me. Just needs a rebase and we can merge |
xg-wang
force-pushed
the
fix/horizontal_bar_label
branch
from
5d5e67f
to
6d1bb3c
Compare
xg-wang
force-pushed
the
fix/horizontal_bar_label
branch
from
4d20b89
to
907ee6c
Compare
|
squashed into 1 commit |
|
Looks like this got fixed in #4425 |
|
Closing per @benmccann's comment |
Currently, when dataset empty, we do not check whether min, max is null.
https://github.com/chartjs/Chart.js/blob/master/src/scales/scale.linear.js#L102-L128
Set it to default if null could prevent axis's ticks array being [0, NaN], which led to the issue #4216