Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid log scale min and max #6058

Merged
merged 7 commits into from Feb 24, 2019
Merged

Ignore invalid log scale min and max #6058

merged 7 commits into from Feb 24, 2019

Conversation

benmccann
Copy link
Contributor

Currently the log scale fails to render if a negative value is passed to it. This changes it to ignore the invalid value instead

@benmccann benmccann mentioned this pull request Feb 9, 2019
Closed
simonbrunel
simonbrunel previously approved these changes Feb 13, 2019
View reviewed changes
@simonbrunel simonbrunel added this to the Version 2.8 milestone Feb 13, 2019
nagix
nagix previously approved these changes Feb 13, 2019
View reviewed changes
kurkle
kurkle previously approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but I hate those undefined's that don't minify, so gave a suggestion 🙊

src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved
src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved
src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved
@benmccann benmccann dismissed stale reviews from kurkle, nagix, and simonbrunel via 4fc7704 February 14, 2019 00:05
@simonbrunel simonbrunel merged commit 317cae1 into chartjs:master Feb 24, 2019
@simonbrunel
Copy link
Member

Thanks @benmccann

@jledentu jledentu mentioned this pull request Oct 28, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Ignore invalid log scale min and max (chartjs#6058)
06bc839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagix nagix nagix approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benmccann @simonbrunel @nagix @etimberg @kurkle