Fix zooming clears logarithmic scale #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing error: Logarithmic scale gets cleared out by zooming out. Error diagnosis: Minimum value of scale was getting a negative value, logarithmic scales are not able to show negative values -> gets cleared out. Bug fixing: When the scale would get a negative value it will be substituted by 0.
jledentu
requested changes
Feb 7, 2019
jledentu
approved these changes
Feb 8, 2019
|
I created chartjs/Chart.js#6058 as an alternate fix which would potentially allow us to avoid adding special case logic here |
|
@benmccann Nice! Handling this case in the core is actually better! |
|
I'm going to close this since chartjs/Chart.js#6058 was merged Thanks for raising this issue and proposing the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing error: Logarithmic scale gets cleared out by zooming out.
Error diagnosis: Minimum value of scale was getting a negative value, logarithmic scales are not able to show negative values -> gets cleared out.
Bug fixing: When the scale would get a negative value it will be substituted by 0.
Closes #153