Improve linear tick generators collision estimation #8983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8982
Roughly estimate the space needed for min/max tick in scale units.
scale_range / (width / font.lineHeight / 0.7) * number_of_digits
for horizontal,scale_range / (height / fint.lineHeight)
for verticalI'm sure this won't work with all fonts, but its a lot closer to the truth than previous estimation, which is based on the number of spaced between ticks, and does not take the font or chart dimensions into account at all.
0.7
is a quick estimation on the width/height ratio of a digit in average font.