Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for DecimationAlgorithm type #9010

Merged
merged 3 commits into from May 1, 2021
Merged

Add test for DecimationAlgorithm type #9010

merged 3 commits into from May 1, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented May 1, 2021

While investigating #8993 I made this test. Should add it anyway.

@etimberg etimberg added the type: types Typescript type changes label May 1, 2021
@etimberg etimberg added this to the Version 3.2.1 milestone May 1, 2021
kurkle
kurkle previously approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it work with just 'lttb' as well?

@etimberg
Copy link
Member Author

etimberg commented May 1, 2021

It should, but my simple test fails. Will debug a bit further

kurkle
kurkle requested changes May 1, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[lint-types] 1964:41 error Strings must use singlequote

@etimberg etimberg linked an issue May 1, 2021 that may be closed by this pull request
DecimationAlgorithm enum not found #8993
Closed
@etimberg etimberg merged commit ea7b8cb into chartjs:master May 1, 2021
@etimberg etimberg deleted the expose-decimation-algorithm-type branch May 1, 2021 16:36
@etimberg etimberg mentioned this pull request May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.2.1
Development

Successfully merging this pull request may close these issues.

DecimationAlgorithm enum not found
2 participants
@etimberg @kurkle