Add includeBounds option for cartesian ticks #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
May 4, 2021
Good calls, it does not actually even work currently :) |
etimberg
previously approved these changes
May 4, 2021
|
Is this ready to go? |
|
It could be separated to min/max, as it can be scriptable and in that case it would be more versatile. But there is no order for such a thing, so it's ready as far as I'm concerned. |
|
Actually, I'm going to add a fix for #9025 while at it. |
etimberg
approved these changes
May 5, 2021
|
Is there more to do on this, or is it good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is not suited for all use cases, in particular with the
chartjs-plugin-zoomand the fact that when zoomed, the min / max values can vary greatly in precision compared to other ticks.Fixes chartjs/chartjs-plugin-zoom#342